Daniel Erez has uploaded a new change for review. Change subject: core: lsm - lock image on CreateImagePlaceholder phase ......................................................................
core: lsm - lock image on CreateImagePlaceholder phase Lock image on CreateImagePlaceholder phase rather than on LiveSnapshot endSuccessfully(). (prevents locked disks when shutting down the VM during live snapshot). Change-Id: I899e55c995a96f68023e2ad7b31daac57d1e8dbb Bug-Url: https://bugzilla.redhat.com/896445 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/11311/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java index 40e28ba..c2493ea 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java @@ -22,7 +22,8 @@ @Override protected void beforeTask() { - // No-op before the sync image command in the database side + ImagesHandler.updateImageStatus( + getEnclosingCommand().getParameters().getDestinationImageId(), ImageStatus.LOCKED); } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java index 6e9dcf5..bdd1c08 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java @@ -48,7 +48,6 @@ for (LiveMigrateDiskParameters parameters : enclosingCommand.getParameters().getParametersList()) { updateDestinationImageId(parameters); - ImagesHandler.updateImageStatus(parameters.getDestinationImageId(), ImageStatus.LOCKED); } ExecutionHandler.endJob(enclosingCommand.getExecutionContext(), true); -- To view, visit http://gerrit.ovirt.org/11311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I899e55c995a96f68023e2ad7b31daac57d1e8dbb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
