Allon Mureinik has posted comments on this change.
Change subject: core: RemoveImageParameters - added removeDuringExecution flag
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 81: getParameters().getStorageDomainId()));
Line 82:
Line 83: if (getParameters().isRemoveDuringExecution()
Line 84: && getParameters().getParentCommand() !=
VdcActionType.RemoveVmFromImportExport
Line 85: && getParameters().getParentCommand() !=
VdcActionType.RemoveVmTemplateFromImportExport) {
If you already have this flag, why not consolidate the entire flow and make the
given commands set it properly?
Line 86: removeImageFromDB(false);
Line 87: }
Line 88: } else {
Line 89: log.warn("DiskImage is null, nothing to remove");
--
To view, visit http://gerrit.ovirt.org/11330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ba734a97db220f913bdee88dbfeeba76981f5a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
