Alon Bar-Lev has posted comments on this change.
Change subject: host-deploy: utilize engine correlation id
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
Line 11: import org.ovirt.engine.core.utils.log.LogFactory;
Line 12:
Line 13: public class InstallerMessages {
Line 14: private VDS _vds;
Line 15: private String _correlationId;
You should know better than I...
As far as I can see:
AuditLogableBase::public String getCorrelationId()
AuditLogableBase::void setCorrelationId(String correlationId)
So why do you think Guid is appropriate here?
Line 16: private int _sequence = 0;
Line 17:
Line 18: public enum Severity {
Line 19: INFO,
--
To view, visit http://gerrit.ovirt.org/11287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dba5b6d1319f0b4caa6f0d3e77683a098df31e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
