Dave Chen has posted comments on this change. Change subject: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal ......................................................................
Patch Set 1: (2 inline comments) Link to the design page - http://wiki.ovirt.org/Trusted_compute_pools; http://en.wikipedia.org/wiki/Trusted_Execution_Technology .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java Line 518: vmNICs = getVmNetworkInterfaceDao().getAllForVm(getVm().getId()); Line 519: } Line 520: return vmNICs; Line 521: } Line 522: private static boolean validateHostIsTrusted(VDS curVds) { Thanks for reminding me, I have added a link in the commit message. pls feel free to notifiy me if there are something not clear. And I am mostly concerned about is the performance issue, our current consideration is caching all of node's trustworthiness while the first virtual machine's launching, the result may be stored in database or just in system memory, thus, the first virtual machine may take a little longer before running, and the period of validity would be one hour or so, node's status need to be updated in the case of end user reboot the virtual machine and the duration exceed valid time. Does this acceptable and any good suggestion? Line 523: String attestationWSURL, trustStorePath; Line 524: attestationWSURL = Config.<String> GetValue(ConfigValues.AttestationWebServicesUrl); Line 525: trustStorePath=Config.<String> GetValue(ConfigValues.TrustStore); Line 526: DefaultHttpClient httpclient = new DefaultHttpClient(); .................................................... Commit Message Line 3: AuthorDate: 2013-01-19 05:23:18 -0500 Line 4: Commit: Dave Chen <[email protected]> Line 5: CommitDate: 2013-01-19 05:23:18 -0500 Line 6: Line 7: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal Link to the design page - http://wiki.ovirt.org/Trusted_compute_pools; http://en.wikipedia.org/wiki/Trusted_Execution_Technology Line 8: Line 9: Change-Id: I4de780cd46069638433255f3f9c994575f752e55 -- To view, visit http://gerrit.ovirt.org/11237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4de780cd46069638433255f3f9c994575f752e55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dave Chen <[email protected]> Gerrit-Reviewer: Dave Chen <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
