Liron Aravot has posted comments on this change. Change subject: core: persist LUN with correct volume_group_id ......................................................................
Patch Set 1: (4 inline comments) .................................................... Commit Message Line 6: Line 7: core: persist LUN with correct volume_group_id Line 8: Line 9: When saving a LUN object to the db, we specify what is the needed volume Line 10: group. In case of an exist lun - it's volume group id would be updated to Done Line 11: the new given value. In case that the given LUN isn't in the DB, it'll Line 12: be saved - This patch ensures that the saved LUN would be saved with the Line 13: given volume_group_id. Line 14: Line 8: Line 9: When saving a LUN object to the db, we specify what is the needed volume Line 10: group. In case of an exist lun - it's volume group id would be updated to Line 11: the new given value. In case that the given LUN isn't in the DB, it'll Line 12: be saved - This patch ensures that the saved LUN would be saved with the Done Line 13: given volume_group_id. Line 14: Line 15: NOTES: Line 16: Line 13: given volume_group_id. Line 14: Line 15: NOTES: Line 16: Line 17: This motivation for this change is that in cases in which we get the LUN Done Line 18: info from vdsm and the LUN is part of a existing VG, saving it with Line 19: unknown VG to the system will prevent removal of the LUN when it won't Line 20: be used anymore by the system and might cause confusion and inconsistency. Line 21: Line 14: Line 15: NOTES: Line 16: Line 17: This motivation for this change is that in cases in which we get the LUN Line 18: info from vdsm and the LUN is part of a existing VG, saving it with Done Line 19: unknown VG to the system will prevent removal of the LUN when it won't Line 20: be used anymore by the system and might cause confusion and inconsistency. Line 21: Line 22: Change-Id: Ia4404b0d17b107208e5ec00c688db305ba0e65fe -- To view, visit http://gerrit.ovirt.org/10630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4404b0d17b107208e5ec00c688db305ba0e65fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
