Sandro Bonazzola has posted comments on this change. Change subject: WIP: packaging: adding support for ServiceD ......................................................................
Patch Set 3: changing from isServiceAvailable() to available you're assuming nobody disable a service between the call to _initService() and the test on the attribute available. Can you rely on this assumption? -- To view, visit http://gerrit.ovirt.org/11228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33c898b4e4d0334f2e0ee84642dc29b3177d7db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
