Allon Mureinik has submitted this change and it was merged. Change subject: core: Streamline MoveVmCommand.canDoAction ......................................................................
core: Streamline MoveVmCommand.canDoAction MoveVmCommand's constructor uses getVm().getStoragePoolId(), so it is safe to assume that the VM is not null in the canDoAction() method. This method removes this redundant check from canDoAction(), and moves all the initializer logic from it to the constructor, where it belongs. Change-Id: I047f744cdaf8f7b1b5a788c9435642eb05ed6919 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java 1 file changed, 3 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I047f744cdaf8f7b1b5a788c9435642eb05ed6919 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
