Gilad Chaplik has posted comments on this change.
Change subject: engine: Added IsDisplayAddressConsistentInClusterQuery
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostsInClusterPartiallyOverriddenQuery.java
Line 18: protected void executeQueryCommand() {
Line 19: GetHostsByClusterIdParameters params = new
GetHostsByClusterIdParameters(getParameters().getId());
Line 20: params.setFiltered(getParameters().isFiltered());
Line 21:
Line 22: VdcQueryReturnValue hostsReturnValue =
Backend.getInstance().RunQuery(VdcQueryType.GetHostsByClusterId, params);
I don't think that we encapsulate queries that good... so it's better to do the
task yourself
Line 23: @SuppressWarnings("unchecked")
Line 24: List<VDS> hosts = (List<VDS>)
hostsReturnValue.getReturnValue();
Line 25:
getQueryReturnValue().setReturnValue(isConsoleAddressPartiallyOverridden(hosts));
Line 26: }
Line 25:
getQueryReturnValue().setReturnValue(isConsoleAddressPartiallyOverridden(hosts));
Line 26: }
Line 27:
Line 28: boolean isConsoleAddressPartiallyOverridden(List<VDS> hosts) {
Line 29:
agree, let it stay here :)
Line 30: if (hosts == null) {
Line 31: return false;
Line 32: }
Line 33:
--
To view, visit http://gerrit.ovirt.org/11375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1955c35a3739680f6f80c9e8b29a21a14c5b8b7a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
