Alexander Wels has posted comments on this change. Change subject: webadmin: expand all expands selected node ......................................................................
Patch Set 3: (5 inline comments) .................................................... Commit Message Line 11: - Added logic to find the selected node and pass Line 12: that into the node collapse method. Line 13: - Fixed the node collapse to properly collapse all Line 14: sub nodes AND itself. Line 15: - Merged changes from http://gerrit.ovirt.org/#/c/10427/ Well the changes in the patch were incompatible with this change, so I made sure the result of that patch were in this one, that is why I mentioned it here. Line 16: - Fixed code review items. Line 17: Line 18: Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879291 Line 12: that into the node collapse method. Line 13: - Fixed the node collapse to properly collapse all Line 14: sub nodes AND itself. Line 15: - Merged changes from http://gerrit.ovirt.org/#/c/10427/ Line 16: - Fixed code review items. Just so people know I look at their comments and apply suggested changes. Line 17: Line 18: Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879291 .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java Line 32: WidgetUiBinder uiBinder = GWT.create(WidgetUiBinder.class); Line 33: } Line 34: Line 35: private CellTree display; Line 36: private boolean initialized; Right. Line 37: Line 38: public SystemTree(SystemTreeModelProvider modelProvider, ApplicationConstants constants) { Line 39: super(modelProvider); Line 40: initWidget(WidgetUiBinder.uiBinder.createAndBindUi(this)); Line 86: private void addModelListeners(final SystemTreeModelProvider modelProvider) { Line 87: modelProvider.getModel().getItemsChangedEvent().addListener(new IEventListener() { Line 88: @Override Line 89: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 90: // Collapse tree on refresh It showed up when merging the other patch, but you are right it is old code that can be removed. Line 91: collapseTree(display.getRootTreeNode()); Line 92: Line 93: // Workaround for bug 856233. Force a root tree node to be opened. Line 94: // This won't cause visual changes, i.e. after refresh the tree Line 119: private void expandTree(TreeNode node) { Line 120: expandTree(node, ROOT_LEVEL); Line 121: } Line 122: Line 123: private void expandTree(TreeNode node, int expandFromLevel) { Done Line 124: if (node == null) { Line 125: return; Line 126: } Line 127: for (int i = 0; i < node.getChildCount(); i++) { -- To view, visit http://gerrit.ovirt.org/10913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
