Allon Mureinik has posted comments on this change.

Change subject: core: Fixing duplicate scripts recognition
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

please fix the typo in the commit message when you rebase

....................................................
Commit Message
Line 6: 
Line 7: core: Fixing duplicate scripts recognition
Line 8: 
Line 9: The upgrade utility should recognize that a script was installed before
Line 10: with a different prefix in order to only record it an skip its 
execution.
s/an/and/
Line 11: This is done by recording in the database the md5 for each upgrade
Line 12: script so if a script is already installed and have the current script
Line 13: md5 , the new script will be recorded to the schema_version with a
Line 14: SKIPPED state and a comment saying which is the script that was already


--
To view, visit http://gerrit.ovirt.org/11381
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e887acc0e3bb266354af2ac5e77e5aec8537454
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to