Gilad Chaplik has posted comments on this change.
Change subject: core: Fix UpdateVm permissions check for Quota
......................................................................
Patch Set 1: (1 inline comment)
I disagree with this change:
The user can't reach a situation where he selects a quota that he doesn't have
permission on, so this fix doesn't really fix the specific problem.
In the rest, when incorporated, a user should fail when supplying quota with no
permission.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 904: }
Line 905: return true;
Line 906: }
Line 907:
Line 908: public void addQuotaPermissionSubject(List<PermissionSubject>
quotaPermissionList) {
please override this method in updateVmCommand
Line 909: if (!isInternalExecution() && getStoragePool() != null
Line 910: && getStoragePool().getQuotaEnforcementType() !=
QuotaEnforcementTypeEnum.DISABLED
Line 911: && getStoragePool().getQuotaEnforcementType() !=
QuotaEnforcementTypeEnum.SOFT_ENFORCEMENT) {
Line 912:
--
To view, visit http://gerrit.ovirt.org/11418
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
