Allon Mureinik has posted comments on this change. Change subject: core(WIP): Use audit log instead block. ......................................................................
Patch Set 2: I would prefer that you didn't submit this Agreed with mkublin - I don't think auditlogs are appropriate here. I'd change the method's signature to return a ValidationResult instead of just a boolean, and attach a relevant canDo message on it. -- To view, visit http://gerrit.ovirt.org/11407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia910b83d4dedefc9c22d0c30bc099fa5fb628355 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
