Maor Lipchuk has posted comments on this change.
Change subject: core: Rename wrong method name.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/command/utils/StorageDomainSpaceChecker.java
Line 6: import org.ovirt.engine.core.common.config.ConfigValues;
Line 7:
Line 8: public class StorageDomainSpaceChecker {
Line 9:
Line 10: public static boolean isAboveThresholds(final storage_domains
domain) {
It gives a connotation that the storage and the threshold has the same value.
Any other suggestions?
Line 11: return isEnoughFreeSpace(domain) && isEnoughFreePct(domain);
Line 12: }
Line 13:
Line 14: private static boolean isEnoughFreePct(final storage_domains
domain) {
--
To view, visit http://gerrit.ovirt.org/11406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa8bf68d35181fde5f2a5ef813d65b3653505411
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
