Allon Mureinik has posted comments on this change.
Change subject: core: Streamline RestoreAllSnapshots.canDoAction
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 307: !validate(vmValidator.vmDown())) {
Line 308: return false;
Line 309: }
Line 310:
Line 311: Snapshot snapshot =
getSnapshotDao().get(getParameters().getDstSnapshotId());
I did not move it.
See line 305 of the old version - performImagesChecks was there too.
I agree the order of the entire method could (should!) be reworked, but not as
part of this patch - it only deals with formatting and readability, and does
not change any logic.
Line 312: if (snapshot.getType() == SnapshotType.REGULAR
Line 313: && snapshot.getStatus() != SnapshotStatus.IN_PREVIEW)
{
Line 314: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_SNAPSHOT_NOT_IN_PREVIEW);
Line 315: }
--
To view, visit http://gerrit.ovirt.org/11446
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06cd91e90cbe8ec10ad3e50b98c04796222e813
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
