Moti Asayag has posted comments on this change. Change subject: engine: Created DB function fn_get_comparable_ip_list ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/dbscripts/create_functions.sql Line 672: Line 673: -- This function turns a string of IP addresses to an array of IP Line 674: -- addreses, in order to correct sorting. Line 675: CREATE OR REPLACE FUNCTION fn_get_comparable_ip_list(text) RETURNS inet[] Line 676: AS $function$ It doesn't have any significance. you can use $BODY$ if wishes and it still works the same. But for the sake of compliance to other functions i find $function$ better suited. Line 677: SELECT CASE Line 678: WHEN $1 SIMILAR TO ' *' THEN NULL Line 679: ELSE regexp_split_to_array(trim(both from $1), '\s+')::inet[] Line 680: END; -- To view, visit http://gerrit.ovirt.org/11432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d29697e34c94fdc1321db2318d0e12fe27643da Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
