Gilad Chaplik has posted comments on this change.
Change subject: core: Enable remove quota when quota is not enforced
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java
Line 37: return false;
Line 38: }
Line 39:
Line 40: // If the quota is in use by ether VM or image - return false
Line 41: if (getQuotaDAO().isQuotaInUse(quota) &&
!quota.getQuotaEnforcementType().equals(QuotaEnforcementTypeEnum.DISABLED)) {
switch:
const.equal(nullable) instead of nullable.equal(const)
Line 42:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_QUOTA_IN_USE_BY_VM_OR_DISK);
Line 43: return false;
Line 44: }
Line 45:
Line 38: }
Line 39:
Line 40: // If the quota is in use by ether VM or image - return false
Line 41: if (getQuotaDAO().isQuotaInUse(quota) &&
!quota.getQuotaEnforcementType().equals(QuotaEnforcementTypeEnum.DISABLED)) {
Line 42:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_QUOTA_IN_USE_BY_VM_OR_DISK);
please update the message accordingly.
quota is in use and DC isn't disabled (also change the enum)
Line 43: return false;
Line 44: }
Line 45:
Line 46: // Otherwise
--
To view, visit http://gerrit.ovirt.org/11505
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95ff993b0db21a17e62e3258338bd524c5c8b957
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
