Alex Lourie has posted comments on this change.
Change subject: packaging: use APP_NAME in /etc/exports comments
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 1738: os.makedirs(controller.CONF["NFS_MP"])
Line 1739: # Add export to exportfs
Line 1740: nfsutils.addNfsExport(controller.CONF["NFS_MP"],
Line 1741: (("0.0.0.0", "0.0.0.0", ("rw",)),),
Line 1742: "%s installer" % basedefs.APP_NAME)
Reviewing what we currently do, I'd put one space character here, to make it
prettier.
Line 1743:
Line 1744: # Add warning to user about nfs export permissions
Line 1745:
controller.MESSAGES.append(output_messages.WARN_ISO_DOMAIN_SECURITY %
(controller.CONF["NFS_MP"]))
Line 1746:
--
To view, visit http://gerrit.ovirt.org/11506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7c343408d586f756251247da51a3412a5a9afdd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
