Allon Mureinik has posted comments on this change. Change subject: core:Switch between percentage and space validation. ......................................................................
Patch Set 2: Looks good to me, approved (3 inline comments) Some minor uses in the commit message. Please fix 'em when you rebase. .................................................... Commit Message Line 3: AuthorDate: 2013-01-24 17:35:59 +0200 Line 4: Commit: Maor Lipchuk <[email protected]> Line 5: CommitDate: 2013-01-29 20:03:57 +0200 Line 6: Line 7: core:Switch between percentage and space validation. missing space after "core:" Line 8: Line 9: The validation today validates storage free space in a method called Line 10: check percentage free space and vise versa, this method names should be Line 11: switched. Line 6: Line 7: core:Switch between percentage and space validation. Line 8: Line 9: The validation today validates storage free space in a method called Line 10: check percentage free space and vise versa, this method names should be s/this/these/ Line 11: switched. Line 12: Line 13: Also use the calculation introduced at change id Line 14: Ic9c03538a4c6173bd8eb5c0f35f665659afcff2d for this validation. Line 9: The validation today validates storage free space in a method called Line 10: check percentage free space and vise versa, this method names should be Line 11: switched. Line 12: Line 13: Also use the calculation introduced at change id s/at/in/ Line 14: Ic9c03538a4c6173bd8eb5c0f35f665659afcff2d for this validation. Line 15: Line 16: Change-Id: I4612035dc5e93c7dea872b23d274724154530395 Line 17: Related-to: https://bugzilla.redhat.com/856201 -- To view, visit http://gerrit.ovirt.org/11405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4612035dc5e93c7dea872b23d274724154530395 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
