Oved Ourfali has posted comments on this change.
Change subject: engine : Webadmin won't let user login in second tab
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
Some minor comments
Also, please verify that this scenario works:
1. You have one tab where you're logged in.
2. You open another tab and browse to webadmin
3. You are supposed to be automatically logged in... so just make sure it works
(should work).
Thank you,
Oved
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
Line 154: return true;
Line 155: }
Line 156:
Line 157: protected boolean isUserCanBeAuthenticated() {
Line 158: boolean authenticated = authenticateWithLdap();
not necessarily with LDAP. change to "authenticateUser" or something similar.
Line 159: if (authenticated) {
Line 160: /*
Line 161: * Check login permissions
Line 162: * We do it here and not via the
getPermissionCheckSubjects mechanism, because we need the user to be logged in
to
Line 181: }
Line 182:
Line 183: private boolean authenticateWithLdap() {
Line 184: boolean domainFound = false;
Line 185: List<String> vdcDomains = LdapBrokerUtils.getDomainsList();
put in a "findDomain" method.
Line 186: for (String domain : vdcDomains) {
Line 187: if (StringUtils.equals(domain.toLowerCase(),
getDomain().toLowerCase())) {
Line 188: domainFound = true;
Line 189: break;
--
To view, visit http://gerrit.ovirt.org/11261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80c1857ce344330bcf0588ae6c9ddc7eb5d9e4aa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
