Mike Kolesnik has posted comments on this change.
Change subject: engine: Moving Duplicate Code to Base Class
......................................................................
Patch Set 3: (1 inline comment)
Looks good, Just one comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
Line 27: import
org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogField;
Line 28: import
org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogFields;
Line 29:
Line 30: @SuppressWarnings("serial")
Line 31: @NonTransactiveCommandAttribute(forceCompensation = true)
Don't think this annotation should move since it's not inheritable
Line 32: @CustomLogFields({ @CustomLogField("NetworkName"),
@CustomLogField("InterfaceName") })
Line 33: public abstract class AbstractVmInterfaceCommand<T extends
AddVmInterfaceParameters> extends VmCommand<T> {
Line 34:
Line 35: public AbstractVmInterfaceCommand(T parameters) {
--
To view, visit http://gerrit.ovirt.org/11362
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b07249bc2e554e2a420792fd100781dff748958
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
