Omer Frenkel has posted comments on this change.
Change subject: engine: Add per-VM VncKeyboardLayout
......................................................................
Patch Set 2: (4 inline comments)
i think this patch should come before the rest api patch, because if for some
reason the rest patch will be merged before this one does, we will have errors.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 88: "images", // images list is relational entity - ignore
value changes
Line 89: "interfaces", // interfaces is relational entity -
ignore value changes
Line 90: "useHostCpuFlags",
Line 91: "quotaDefault",
Line 92: "vncKeyboardLayout"
not sure about this, if the field is added here, the user can update it while
the vm is running, but the value is only sent in createVm, so if user change it
after running the vm, the value will not change "dynamicaly"
maybe better add it on the list below, of fields allowed to update when vm is
down
Line 93: });
Line 94: mUpdateVmsStatic.AddFields(
Line 95: Arrays.asList(new Enum<?>[] { VMStatus.Down }),
Line 96: Arrays.asList(new String[] { "vdsGroupId", "timeZone",
"stateless", "niceLevel", "memSizeMb",
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
Line 35: "defaultBootSequence", "disabled",
Line 36: "isoPath", "diskImageMap", "defaultDisplayType",
"priority", "autoStartup", "stateless",
Line 37: "initrdUrl", "kernelUrl", "kernelParams", "images",
"interfaces", "quotaId", "quotaName",
Line 38: "quotaEnforcementType", "migrationSupport",
"dedicatedVmForVds", "smartcardEnabled","dbGeneration", "deleteProtected",
Line 39: "quotaDefault", "vncKeyboardLayout",
there is an extra ',' in the end here
Line 40: });
Line 41: }
Line 42:
Line 43: public static void UpdateDisksFromDb(VmTemplate vmt) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 187: @Column(name = "default_display_type")
Line 188: @Enumerated
Line 189: protected DisplayType defaultDisplayType = DisplayType.qxl;
Line 190:
Line 191: @Column(name = "vnc_keyboard_layout")
no need for the jpa annotations, there is another patch that remove all current
ones
Line 192: @NullOrStringContainedInConfigValueList(configValue =
ConfigValues.VncKeyboardLayoutValidValues,
Line 193: groups = { CreateEntity.class, UpdateEntity.class },
Line 194: message = "VALIDATION.VM.INVALID_KEYBOARD_LAYOUT")
Line 195: private String vncKeyboardLayout;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
Line 228: entity.setQuotaName(rs.getString("quota_name"));
Line 229:
entity.setQuotaEnforcementType(QuotaEnforcementTypeEnum.forValue(rs.getInt("quota_enforcement_type")));
Line 230:
entity.setMigrationSupport(MigrationSupport.forValue(rs.getInt("migration_support")));
Line 231:
entity.setDedicatedVmForVds(NGuid.createGuidFromString(rs.getString("dedicated_vm_for_vds")));
Line 232: entity.setDisabled(rs.getBoolean("is_disabled"));
missing set here
Line 233: return entity;
Line 234: }
Line 235: }
Line 236:
--
To view, visit http://gerrit.ovirt.org/11314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73338ce279aa4f14f1332dbdebb1dd0f1cec974
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Beták <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
