Sandro Bonazzola has posted comments on this change.
Change subject: packaging: allow importing existing ISO domain on setup
......................................................................
Patch Set 2: (3 inline comments)
replied to inline comments
....................................................
File packaging/fedora/setup/engine-setup.py
Line 465: "OPTION_LIST" :[],
Line 466: "VALIDATION_FUNC" :validate.validateNFSMountPoint,
Line 467: "DEFAULT_VALUE" :generateIsoDomainName(),
Line 468: "MASK_INPUT" : False,
Line 469: "LOOSE_VALIDATION": True,
If we remove this from here, we have to ask later if the user want to re-import
the existing domain or choose another path, right? So I thought it would be
simpler just reuse the existing structure.
Line 470: "CONF_NAME" : "NFS_MP",
Line 471: "USE_DEFAULT" : False,
Line 472: "NEED_CONFIRM" : False,
Line 473: "CONDITION" : False},
Line 1738: logging.debug("creating directory %s " %
(controller.CONF["NFS_MP"]))
Line 1739: os.makedirs(controller.CONF["NFS_MP"])
Line 1740:
Line 1741: # Add export to exportfs if not already there
Line 1742: if not validate.isPathInExportFs(controller.CONF["NFS_MP"]):
Sounds good to me
Line 1743: nfsutils.addNfsExport(controller.CONF["NFS_MP"],
Line 1744: (("0.0.0.0", "0.0.0.0", ("rw",)),),
Line 1745: " %s installer" %
basedefs.APP_NAME)
Line 1746:
Line 1767: controller.CONF["sd_uuid"] = str(entry)
Line 1768: except ValueError:
Line 1769: #Should we abort if something else exists here?
Line 1770: continue
Line 1771: else:
http://docs.python.org/2/tutorial/controlflow.html#break-and-continue-statements-and-else-clauses-on-loops
Line 1772: # Generate the UUID for the isodomain
Line 1773: controller.CONF["sd_uuid"] = nfsutils.generateUUID()
Line 1774:
Line 1775: # Create ISO domain
--
To view, visit http://gerrit.ovirt.org/11556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4343f8374e6439b0ee0a14fff233a0d4a0d5a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
