Alexander Wels has posted comments on this change. Change subject: userportal: set grid's items only on change ......................................................................
Patch Set 3: Patch 3 addresses issue #1 (the equals in vm_pools not working properly due to checking defaultStartTime and defaultEndTime). I had to pull in getId() from the other patch because it was not defined in the master. Issue #2 turns out NOT to be an issue. the equals method in VmStatic calls super.equals which checks all the fields defined in the super class, including the number of monitors and things like that. -- To view, visit http://gerrit.ovirt.org/10579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bd8c3cb312f89125e8c0a0182f49fe74f9f02d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
