Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: Added caching ......................................................................
Patch Set 11: Verified Rebased, improved and verified, take two. I've addressed some issues mentioned in my previous comments. The idea of introducing servlet 3.0 annotations is nice, but the fact that same filters/servlets get applied to different contexts is NOT nice. [In particular, servlet 3.0 annotations DO NOT allow defining @WebServlet/@WebFilter without specifying URL patterns, which limits their usage.] frontend-overlay is now packaged as JAR instead of WAR and WebAdmin/UserPortal declare it as runtime dependency, placed in WEB-INF/lib, right next to frontend JAR. >From servlet 3.0 API perspective, frontend-overlay is web fragment module, >defining common filters/servlets for WebAdmin/UserPortal, as well as >containing common resources under META-INF/resources, such as GwtHostPage.jsp. >WebAdmin/UserPortal WAR now includes both frontend + frontend-overlay JARs >within WEB-INF/lib, there's no classes directory anymore, nor there should be >one (WAR dependencies should be properly packaged, extracting stuff directly >to WEB-INF/classes is bad practice). [frontend JAR is required due to >frontend-overlay JAR depending on Generic API RPC interface.] GenericApiGWTServiceImpl (Generic API servlet) was moved to frontend-overlay, frontend is now purely common GWT code (I've also updated frontend GWT module descriptor accordingly). I've also updated "no-cache" init-param value so that UI plugin static resources served via GwtCachingFilter are now treated as "Resources which always need to be checked for changes". Last but not least, I've removed AbstractGWTServiceImpl since it was just an empty class (GenericApiGWTServiceImpl now extends RpcServlet directly). The concept of servlet 3.0 web fragment used in frontend-overlay allows us to define common filters/servlets/resources in a shared module (frontend-overlay), and put them into use in a specific WAR (WebAdmin/UserPortal). -- To view, visit http://gerrit.ovirt.org/10449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d8e02ae542a4aa37bd421bde5582c0f3e9820ad Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
