Allon Mureinik has uploaded a new change for review. Change subject: core: Remove LdapIsComputerWithTheSameNameExists ......................................................................
core: Remove LdapIsComputerWithTheSameNameExists This command is just dead code - its executeQuery() method is completely commented out, and it has no entry in VdcActionType, so there is no way of calling it. Change-Id: Id8db1e4174922d353ebcc1fc415b677e8ec69930 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapIsComputerWithTheSameNameExistsCommand.java 1 file changed, 0 insertions(+), 54 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/11630/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapIsComputerWithTheSameNameExistsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapIsComputerWithTheSameNameExistsCommand.java deleted file mode 100644 index 7d3b257..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapIsComputerWithTheSameNameExistsCommand.java +++ /dev/null @@ -1,54 +0,0 @@ -package org.ovirt.engine.core.bll.adbroker; - -import org.ovirt.engine.core.compat.StringHelper; - -// -// JTODO - this needs testing -- Livnat -// - -//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -// Unimplemented for now. We leave the code for future implementations -//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -/** - * Determines whether [is computer with the same name exists]. - * - * @param userName - * Name of the user. - * @param password - * The password. - * @param domain - * The domain. - * @param computerName - * Name of the computer. - * @return <c>true</c> if [is computer with the same name exists]; otherwise, - * <c>false</c>. - */ -public class LdapIsComputerWithTheSameNameExistsCommand extends LdapBrokerCommandBase { - private String getComputerName() { - return ((LdapIsComputerWithSameNameExistsParameters) getParameters()).getComputerName(); - } - - public LdapIsComputerWithTheSameNameExistsCommand(LdapIsComputerWithSameNameExistsParameters parameters) { - super(parameters); - if (StringHelper.isNullOrEmpty(getPassword())) { - // setLoginName(mDefaultUserName); - // setPassword(mDefaultUserPassword); - String domain = LdapBrokerUtils.getDomainsList().get(0); - setDomain(domain); - } - } - - @Override - protected void executeQuery(DirectorySearcher directorySearcher) { -// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -// Unimplemented for now. We leave the code for future implementations -// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -// check that there is no computer with the same name. -// directorySearcher.Filter = String.format(AdBrokerLDAPQueries.GET_COMPUTER_BY_NAME, getComputerName()); -// directorySearcher.searchScope = SearchControls.SUBTREE_SCOPE; -// Object objResult = directorySearcher.FindOne(new EmptyAttributeMapper()); - -// setReturnValue(objResult != null); - setReturnValue(false); - } -} -- To view, visit http://gerrit.ovirt.org/11630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8db1e4174922d353ebcc1fc415b677e8ec69930 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
