Alex Lourie has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
2 small comments inline.
....................................................
File packaging/fedora/setup/engine-cleanup.py
Line 164: if not options.unattended_clean:
Line 165: options.remove_nfs_exports =
askYesNo(MSG_CLEAN_NFS_EXPORTS_QUESTION)
Line 166: if not options.remove_nfs_exports:
Line 167: logging.debug("User chose to not clean NFS exports")
Line 168: return False
simple return is enough, no need to give meaning to the value.
Line 169: logging.debug("User chose to clean NFS exports")
Line 170: removed = nfsutils.cleanNfsExports(" %s installer" %
basedefs.APP_NAME)
Line 171: if len(removed) == 0:
Line 172: return True
Line 168: return False
Line 169: logging.debug("User chose to clean NFS exports")
Line 170: removed = nfsutils.cleanNfsExports(" %s installer" %
basedefs.APP_NAME)
Line 171: if len(removed) == 0:
Line 172: return True
same as above
Line 173: nfsutils.refreshNfsExports()
Line 174: path_list = ""
Line 175: for p in removed:
Line 176: path_list += "- %s\n" % p
--
To view, visit http://gerrit.ovirt.org/11548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
