Liron Aravot has posted comments on this change.
Change subject: core: Clean up RemoveStoragePool.canDoAction
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
Line 282:
Line 283: @Override
Line 284: protected boolean canDoAction() {
Line 285: if (!super.canDoAction() ||
Line 286: checkStoragePool() ||
i guess it should be
!checkStoragePool() || !CheckStoragePoolStatusNotEqual(StoragePoolStatus.Up
Line 287: CheckStoragePoolStatusNotEqual(StoragePoolStatus.Up,
Line 288:
VdcBllMessages.ERROR_CANNOT_REMOVE_ACTIVE_STORAGE_POOL)) {
Line 289: return false;
Line 290: }
--
To view, visit http://gerrit.ovirt.org/11634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa157b7589b3ae5039c71ca07c3dc11ff88ce0d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
