Allon Mureinik has uploaded a new change for review.
Change subject: core: Don't check equality in BE setters
......................................................................
core: Don't check equality in BE setters
Some old business entities used the change-check idiom in their setters:
public void setXXX (Object newValue) {
if (!newValue.equals(dataMember) {
dataMember = newValue;
}
}
This was probably produced by the C# conversion, but is completely
useless in Java - in any event, at the end of the setXXX method the
dataMember's value will be equal to the one passed, and the equality
check is more expensive than just assigning the new value.
This patch removes this old idiom from the code.
As a nice side-bonus, it also removes a couple of StringHelper usages
from the code, as part of the ongoing effort to get rid of this class.
Change-Id: Iafac9ca646c6c988470bf49d0596d973531c4616
Signed-off-by: Allon Mureinik <[email protected]>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
4 files changed, 4 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/11638/1
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
index ddeca07..df66f3f 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
@@ -248,9 +248,7 @@
}
public void setname(String value) {
- if (!StringHelper.EqOp(this.name, value)) {
- this.name = value;
- }
+ this.name = value;
}
public String getnote() {
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
index 6431cfa..2150c18 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
@@ -21,7 +21,6 @@
import org.ovirt.engine.core.common.validation.group.UpdateEntity;
import org.ovirt.engine.core.compat.Guid;
import org.ovirt.engine.core.compat.NGuid;
-import org.ovirt.engine.core.compat.StringHelper;
public class VmTemplate extends VmBase implements Nameable {
private static final long serialVersionUID = -522552511046744989L;
@@ -120,9 +119,7 @@
}
public void setname(String value) {
- if (!StringHelper.EqOp(this.name, value)) {
- this.name = value;
- }
+ this.name = value;
}
public VmTemplateStatus getstatus() {
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
index 062be5e..de44217 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
@@ -5,7 +5,6 @@
import org.ovirt.engine.core.common.errors.VdcBllErrors;
import org.ovirt.engine.core.compat.Guid;
import org.ovirt.engine.core.compat.NGuid;
-import org.ovirt.engine.core.compat.StringHelper;
public class storage_domains extends IVdcQueryable implements
BusinessEntity<Guid> {
private static final long serialVersionUID = -6162192446628804305L;
@@ -108,9 +107,7 @@
}
public void setstorage_name(String value) {
- if (!StringHelper.EqOp(getStorageStaticData().getstorage_name(),
value)) {
- getStorageStaticData().setstorage_name(value);
- }
+ getStorageStaticData().setstorage_name(value);
}
public NGuid getstorage_pool_id() {
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
index d5f7bee..71a2a36 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
@@ -11,7 +11,6 @@
import org.ovirt.engine.core.common.validation.group.UpdateEntity;
import org.ovirt.engine.core.compat.Guid;
import org.ovirt.engine.core.compat.StringFormat;
-import org.ovirt.engine.core.compat.StringHelper;
import org.ovirt.engine.core.compat.TimeSpan;
public class vm_pools extends IVdcQueryable implements Serializable {
@@ -248,9 +247,7 @@
}
public void setvm_pool_name(String value) {
- if (!StringHelper.EqOp(this.name, value)) {
- this.name = value;
- }
+ this.name = value;
}
public int getvm_assigned_count() {
--
To view, visit http://gerrit.ovirt.org/11638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafac9ca646c6c988470bf49d0596d973531c4616
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
