Yair Zaslavsky has posted comments on this change. Change subject: core: Custom Materialized Views should be... ......................................................................
Patch Set 1: (1 inline comment) By the way, maybe we would like to add a function of createcustommaterializedview? .................................................... File backend/manager/dbscripts/materialized_views_sp.sql Line 56: END; Line 57: $$ LANGUAGE 'plpgsql' IMMUTABLE STRICT; Line 58: Line 59: -- CreateMaterializedViewAsCreates a new Materialized View Line 60: CREATE OR REPLACE FUNCTION CreateMaterializedView(v_matview NAME, v_view_name NAME, v_refresh_rate_in_sec INTEGER, A suggestion - what about adding a function for CreateCustomMaterializedView which will call CreateMaterializedView with boolean of v_custom set to true? Line 61: v_custom BOOLEAN, v_min_refresh_rate_in_sec INTEGER) Line 62: RETURNS VOID Line 63: AS $procedure$ Line 64: DECLARE -- To view, visit http://gerrit.ovirt.org/11669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6857a1691c1dafa1a7edcd58b292e70c78b318 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
