Liron Aravot has uploaded a new change for review. Change subject: core: attach sd - avoid failover in case of export domain ......................................................................
core: attach sd - avoid failover in case of export domain When attaching an export storage domain and having a failure which isn't spm/master domain related, avoid failover. Change-Id: Iea8ae06d5327e46b5cdb7ed73239744a1ba6ffc3 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/11677/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java index 6910d07..5a4b386 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java @@ -1,6 +1,10 @@ package org.ovirt.engine.core.vdsbroker.irsbroker; +import org.ovirt.engine.core.common.businessentities.StorageDomainType; +import org.ovirt.engine.core.common.businessentities.storage_domains; import org.ovirt.engine.core.common.vdscommands.*; +import org.ovirt.engine.core.dal.dbbroker.DbFacade; +import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSExceptionBase; public class AttachStorageDomainVDSCommand<P extends AttachStorageDomainVDSCommandParameters> extends IrsBrokerCommand<P> { @@ -14,4 +18,13 @@ getParameters().getStoragePoolId().toString()); ProceedProxyReturnValue(); } + + @Override + protected VDSExceptionBase createDefaultConcreteException(String errorMessage) { + storage_domains domainFromDb = DbFacade.getInstance().getStorageDomainDao().get(getParameters().getStorageDomainId()); + if (domainFromDb.getstorage_domain_type() == StorageDomainType.ImportExport) { + return new IrsOperationFailedNoFailoverException(errorMessage); + } + return super.createDefaultConcreteException(errorMessage); + } } -- To view, visit http://gerrit.ovirt.org/11677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea8ae06d5327e46b5cdb7ed73239744a1ba6ffc3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
