Alissa Bonas has posted comments on this change.
Change subject: core: Removed the LongCompat class
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 719: // need int.
Line 720: stringValue = stringValue.split("[.]", -1)[0];
Line 721: }
Line 722: try {
Line 723: return Long.parseLong(stringValue);
I would extract here the variable and not return the expression straight away
because it can throw an exception and then it's hard to find/debug it.
Line 724: } catch (NumberFormatException e) {
Line 725: log.errorFormat("Failed to parse {0} value {1} to
long", name, stringValue);
Line 726: }
Line 727: }
--
To view, visit http://gerrit.ovirt.org/11666
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b672f3406ce7b3316a5ff1b50379d92eedb062
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
