Mike Kolesnik has uploaded a new change for review. Change subject: engine: Use standard audit log fields mechanism ......................................................................
engine: Use standard audit log fields mechanism No need to set fields using the method, we can use the standard annotations mechanism. Change-Id: I96acc0f97a5304838db51b91d7bc7c64678d0181 Bug-Url: https://bugzilla.redhat.com/907155 Signed-off-by: Mike Kolesnik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/11697/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java index b5f5182..9d20405 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java @@ -17,6 +17,8 @@ import org.ovirt.engine.core.common.vdscommands.VmNicDeviceVDSParameters; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.dal.VdcBllMessages; +import org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogField; +import org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogFields; import org.ovirt.engine.core.dao.network.InterfaceDao; import org.ovirt.engine.core.utils.transaction.TransactionMethod; import org.ovirt.engine.core.utils.transaction.TransactionSupport; @@ -27,6 +29,7 @@ */ @SuppressWarnings("serial") @NonTransactiveCommandAttribute +@CustomLogFields({ @CustomLogField("InterfaceName"), @CustomLogField("InterfaceType") }) public class ActivateDeactivateVmNicCommand<T extends ActivateDeactivateVmNicParameters> extends VmCommand<T> { private VmDevice vmDevice; @@ -69,11 +72,16 @@ return vmNetworkInterface == null ? null : vmNetworkInterface.getNetworkName(); } + public String getInterfaceName() { + return vmNetworkInterface.getName(); + } + + public String getInterfaceType() { + return VmInterfaceType.forValue(vmNetworkInterface.getType()).getDescription(); + } + @Override protected void executeVmCommand() { - AddCustomValue("InterfaceName", vmNetworkInterface.getName()); - AddCustomValue("InterfaceType", VmInterfaceType.forValue(vmNetworkInterface.getType()) - .getDescription()); // HotPlug in the host is called only if the Vm is UP if (hotPlugVmNicRequired(getVm().getStatus())) { runVdsCommand(getParameters().getAction().getCommandType(), -- To view, visit http://gerrit.ovirt.org/11697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I96acc0f97a5304838db51b91d7bc7c64678d0181 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
