Vojtech Szocs has posted comments on this change. Change subject: webadmin: UI-Plugins - VM IP address mapping ......................................................................
Patch Set 1: Looks good to me, approved In future, we're planning to use generated classes from "restapi-definition" module and map them to corresponding JavaScript objects to be passed to UI plugins. So in future we should consider having "<vmEntity>.guestInfo.ips[0].address". For now, custom "ipaddress" property is OK. -- To view, visit http://gerrit.ovirt.org/11421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24b1208031d454d1774a43ddb0cccd7a85f23d2e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
