Liron Aravot has posted comments on this change.
Change subject: core: GetAllDisksBySD - fetch disks snapshots
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java
Line 33: // Update diskImages' snapshots
Line 34: for (DiskImage diskImage : diskImages) {
Line 35: if (!diskImage.getactive()) {
Line 36:
diskImagesMap.get(diskImage.getId()).getSnapshots().add(diskImage);
Line 37: }
basically you could save the non active disks aside on the first loop and then
iterate only over them, but i guess that its not really an issue..+1.
Line 38: }
Line 39:
Line 40: getQueryReturnValue().setReturnValue(new
ArrayList<DiskImage>(diskImagesMap.values()));
Line 41: }
--
To view, visit http://gerrit.ovirt.org/11640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I055e317ea21a9eabea126e9ca17af61db659cd10
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
