Libor Spevak has posted comments on this change.

Change subject: webadmin: Restrict destination host parameter for administrator 
only
......................................................................


Patch Set 1:

Could you please advise me, if you see any solution to this requirement? The 
frontend side is merged to upstream, but waits for the backend authorization.

1. As I understand from the REST API point of view, there could be conflict if 
the user is not of admin role for the current solutions

2. Method isAdmin is filled from  
MultiLevelAdministrationHandler.isAdminUser(currentUser), and it is true, if 
user is of any admin role type. It is true for WebAdmin user, for UserPortal it 
could be true, but the user should not select target host.

Are there other relations or consequences?

Thanks.

--
To view, visit http://gerrit.ovirt.org/11303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5294854d24b235f2c50fa7f3d4e7472cf7598b53
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to