Allon Mureinik has posted comments on this change.

Change subject: core: Eliminated use of StringHelper.EqOp
......................................................................


Patch Set 4: Looks good to me, approved

(1 inline comment)

....................................................
Commit Message
Line 5: CommitDate: 2013-02-05 18:24:02 +0200
Line 6: 
Line 7: core: Eliminated use of StringHelper.EqOp
Line 8: 
Line 9: Removed the method StringHelper.EqOp, it was used mainly in 
searchbackend
s/it/which
Line 10: module to check String equality with constants thus it could be 
replaced
Line 11: with standard String implementation of equals and equalsIgnoreCase
Line 12: 
Line 13: Change-Id: Iaf3d65db824f31df05dc7b0eda5f9c24274cf53c


--
To view, visit http://gerrit.ovirt.org/11670
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf3d65db824f31df05dc7b0eda5f9c24274cf53c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to