Michael Pasternak has posted comments on this change. Change subject: api: Current:currents needs to be static to avoid deadly embrace. ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java Line 33 Line 34 Line 35 Line 36 Line 37 "deadly embrace"?, i'd expect it complaining about memory leak, but not deadlock!, - FindBugs ..., though ThreadLocal designed to be static, there is no potential memory leak in this case as ThreadLocal cache been released explicitly by the currents.set(null); at postProcess() and Current itself initiated only once at BackendApplication, acking it just to male FindBugs happy -- To view, visit http://gerrit.ovirt.org/11719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86516044e758aa526f7bab570d41567b35176029 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
