Ofer Schreiber has posted comments on this change.
Change subject: packaging: adding support for ServiceD
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 1220: self.name = name
Line 1221:
Line 1222: # If systemctl exists, we're in SystemD
Line 1223: self.sysd = os.path.exists(basedefs.EXEC_SYSTEMCTL)
Line 1224: # Else, we're in SystemV
new line before #
Line 1225: self.sysv = not self.sysd
Line 1226: # Check service availability
Line 1227: self.available = self._isServiceAvailable()
Line 1228:
Line 1242: sysv = os.path.exists("/etc/init.d/%s" % self.name)
Line 1243: return (sysd or sysv)
Line 1244:
Line 1245: def start(self, raiseFailure=False):
Line 1246: if not self.available:
please create helper function, this code repeat itself
Line 1247: raise OSError(output_messages.ERR_FAILED_START_SERVICE %
self.name)
Line 1248: logging.debug("starting %s", self.name)
Line 1249: (output, rc) = self._serviceFacility("start")
Line 1250: if rc == 0:
--
To view, visit http://gerrit.ovirt.org/11228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33c898b4e4d0334f2e0ee84642dc29b3177d7db
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
