Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Services Query
......................................................................
Patch Set 2: (6 inline comments)
Incorporate review comments. New patch set to follow.
....................................................
File backend/manager/dbscripts/services_sp.sql
Line 59: FROM services
Line 60: WHERE id = v_id;
Line 61: END; $procedure$
Line 62: LANGUAGE plpgsql;
Line 63:
changed to GetServiceConfigByServiceId
Line 64: Create or replace FUNCTION GetServiceConfigById(v_service_id UUID)
Line 65: RETURNS SETOF service_config
Line 66: AS $procedure$
Line 67: BEGIN
....................................................
File backend/manager/dbscripts/upgrade/03_02_0340_add_services_table.sql
Line 20: END IF;
Line 21:
Line 22: DROP INDEX IF EXISTS IDX_services_server_id;
Line 23: CREATE INDEX IDX_services_server_id ON services(server_id);
Line 24: DROP INDEX IF EXISTS IDX_services_name_unique;
Done
Line 25: CREATE INDEX IDX_services_name_unique ON services(server_id,
service_name);
Line 26:
Line 27: -- Add service config table
Line 28: IF (NOT EXISTS (SELECT 1 FROM INFORMATION_SCHEMA.TABLES WHERE
table_name='service_config')) THEN
Line 23: CREATE INDEX IDX_services_server_id ON services(server_id);
Line 24: DROP INDEX IF EXISTS IDX_services_name_unique;
Line 25: CREATE INDEX IDX_services_name_unique ON services(server_id,
service_name);
Line 26:
Line 27: -- Add service config table
Done
Line 28: IF (NOT EXISTS (SELECT 1 FROM INFORMATION_SCHEMA.TABLES WHERE
table_name='service_config')) THEN
Line 29: BEGIN
Line 30: CREATE TABLE service_config
Line 31: (
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceEntity.java
Line 31:
Line 32: private Integer pid;
Line 33:
Line 34: private ServiceStatus status;
Line 35:
Done
Line 36: private ServiceConfigEntity serviceConfig;
Line 37:
Line 38: public ServiceEntity() {
Line 39: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/ServicesDaoDbFacadeImpl.java
Line 36:
Line 37: private void insertService(ServiceEntity service) {
Line 38: getCallsHandler().executeModification("InsertService",
createFullParametersMapper(service));
Line 39: }
Line 40:
Done
Line 41: private void insertServiceConfing(ServiceEntity service) {
Line 42: getCallsHandler().executeModification("InsertServiceConfig",
Line 43: createServiceConfigParams(service.getServiceConfig()));
Line 44: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/ServicesDao.java
Line 20:
Line 21: public List<ServiceEntity> getAllServicesByServerId(Guid serverId);
Line 22:
Line 23: public ServiceEntity getById(Guid serviceId);
Line 24:
Done
Line 25: public ServiceEntity getByName(Guid serviceId, String serviceName);
Line 26:
Line 27: @Override
Line 28: public List<ServiceEntity> getAllWithQuery(String query);
--
To view, visit http://gerrit.ovirt.org/11147
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7982faf180f8580838a962a5674e8e9e8982679b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
