Michael Kublin has uploaded a new change for review. Change subject: engine: Null Pointer Exception when during preview mode action, service ovirt-engine restart ......................................................................
engine: Null Pointer Exception when during preview mode action, service ovirt-engine restart The following bug was caused because of wrong parameter name, these was a cause for not passing serialization by dstSnapshotId, and after restoring it from DB after restart its value was Guid.Empty, so because of that we usually failed at endSuccessfully because of NullPointerException. These is a cause for VM to be stuk in status locked. Change-Id: I273369d20ae3db3e9598f33ff75eb094dd420f65 Bug-Url: https://bugzilla.redhat.com/871802 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/11828/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java index 3f10f3d..a5fea26 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java @@ -4,15 +4,15 @@ public class TryBackToAllSnapshotsOfVmParameters extends VmOperationParameterBase implements java.io.Serializable { private static final long serialVersionUID = 1862924807826485840L; - private Guid _dstSnapshotId = new Guid(); + private Guid dstSnapshotId = Guid.Empty; public TryBackToAllSnapshotsOfVmParameters(Guid vmId, Guid dstSnapshotId) { super(vmId); - _dstSnapshotId = dstSnapshotId; + this.dstSnapshotId = dstSnapshotId; } public Guid getDstSnapshotId() { - return _dstSnapshotId; + return dstSnapshotId; } public TryBackToAllSnapshotsOfVmParameters() { -- To view, visit http://gerrit.ovirt.org/11828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I273369d20ae3db3e9598f33ff75eb094dd420f65 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
