Alex Lourie has posted comments on this change.
Change subject: packaging: Updated pgpass config to avoid password prompts
......................................................................
Patch Set 2: (1 inline comment)
Ofer
The problem is that in 3.1 upstream the .pgpass was created as this:
localhost:5432:engine:engine:<pass>
It means that as soon as we rename the DB from engine to engine_<timestamp>,
user engine can no longer work with it without a password; so the user will be
prompted.
This, this patch intends to fix this by updating the above to
localhost:5432:*:engine:<pass>,
which would allow user engine to work without prompting with all DBs that it
has rights to.
The alternative would be changing the flow to work with postgres user, but this
will only solve "local" installations - we won't have this user in remoteDB
installations, and in those installations we will still be prompted to provide
a password.
....................................................
File packaging/fedora/setup/common_utils.py
Line 870:
Line 871: # Create with updated values
Line 872: with open(basedefs.DB_PASS_FILE, 'w') as pgpass:
Line 873: pgpass.write('\n'.join(newlines))
Line 874:
Yes.
Line 875: logging.debug("INFO: pgpass file was updated.")
Line 876:
Line 877:
Line 878: def backupDB(db, backup_file, env, user, host="localhost",
port="5432"):
--
To view, visit http://gerrit.ovirt.org/11818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica62fe601536d3de92e163a9262f5754b89873ed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
