Bala.FA has posted comments on this change. Change subject: packaging: Application Mode option in installer ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/fedora/setup/basedefs.py Line 179: CONST_CONFIG_EXTRA_IPTABLES_RULES="EXTRA_IPTABLES_RULES" Line 180: CONST_INSTALL_SIZE_MB=500 Line 181: CONST_DOWNLOAD_SIZE_MB=500 Line 182: CONST_DB_SIZE=500 Line 183: CONST_DEFAULT_CLUSTER_ID="99408929-82CF-4DC7-A532-9D998063FA95" Can't this uuid be dynamic? Line 184: CONST_DEFAULT_APPLICATION_MODE="both" Line 185: Line 186: # If following option is True then ApplicationMode set option will not be Line 187: # shown/prompted to the user at the time of engine-setup. Default value will be -- To view, visit http://gerrit.ovirt.org/11801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c958205727905d00f6e407779ee64f5c5eb5a1a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
