Michael Pasternak has posted comments on this change.
Change subject: restapi : version values for hosts are wrong for libvirt
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 273: model.setMaxSchedulingMemory((int)
entity.getMaxSchedulingMemory() * BYTES_IN_MEGABYTE);
Line 274:
Line 275: if (entity.getlibvirt_version() != null &&
Line 276: entity.getlibvirt_version().getMajor() != -1 &&
Line 277: entity.getlibvirt_version().getMinor() != -1 &&
major & minor not enough?
Line 278: entity.getlibvirt_version().getRevision() != -1 &&
Line 279: entity.getlibvirt_version().getBuild() != -1) {
Line 280: Version version = new Version();
Line 281: version.setMajor(entity.getlibvirt_version().getMajor());
--
To view, visit http://gerrit.ovirt.org/11808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c0525b6bb8c90d2ce4e10ac4f5c26f1a1b1e6b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
