Michael Pasternak has posted comments on this change. Change subject: restapi : Multiple events in the UI about logged in user. ......................................................................
Patch Set 1: Do not submit (1 inline comment) in this scenario login should be always validated, to avoid logins/logs, restapi client should be using persistent-authentication .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java Line 70: LoginUserParameters params = new LoginUserParameters(principal.getUser(), Line 71: principal.getSecret(), Line 72: principal.getDomain(), Line 73: null, null, null); Line 74: params.setShouldBeLogged(false); in this scenario login should be always validated Line 75: params.setActionType(VdcActionType.LoginUser); Line 76: sessionHelper.setSessionId(sessionId); Line 77: VdcReturnValueBase ret = backend.Login(sessionHelper.sessionize(params)); Line 78: -- To view, visit http://gerrit.ovirt.org/11713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbce37a8c49b347ad6fa8e9b6489a962623ac525 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
