Muli Salem has uploaded a new change for review. Change subject: core: Add isEmpty Check to MacPoolManager ......................................................................
core: Add isEmpty Check to MacPoolManager This patch adds an isEmpty() check to the freeMacs method, in the MacPoolManager, to avoid entering a synchronized block when unnecessary. Change-Id: Id34bae38c0a05e1e148267950ca1ca464b36daea Bug-Url: https://bugzilla.redhat.com/903572 Signed-off-by: Muli Salem <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/11871/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java index e95fbcf..a3b2bbd 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java @@ -302,17 +302,19 @@ } public void freeMacs(List<String> macs) { - lockObj.writeLock().lock(); - try { - if (!initialized) { - logInitializationError("Failed to free MAC addresses."); - } - for (String mac : macs) { - internalFreeMac(mac); - } + if (!macs.isEmpty()) { + lockObj.writeLock().lock(); + try { + if (!initialized) { + logInitializationError("Failed to free MAC addresses."); + } + for (String mac : macs) { + internalFreeMac(mac); + } - } finally { - lockObj.writeLock().unlock(); + } finally { + lockObj.writeLock().unlock(); + } } } -- To view, visit http://gerrit.ovirt.org/11871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id34bae38c0a05e1e148267950ca1ca464b36daea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
