Yair Zaslavsky has posted comments on this change. Change subject: engine: Get gluster hooks query ......................................................................
Patch Set 8: I would prefer that you didn't submit this (6 inline comments) Please see inline comments. .................................................... File backend/manager/dbscripts/gluster_hooks_sp.sql Line 43: END; $procedure$ Line 44: LANGUAGE plpgsql; Line 45: Line 46: Line 47: Create or replace FUNCTION GetGlusterHookByName(v_cluster_id UUID, v_name VARCHAR(1000)) Why did you add the cluster_id parameter to this pgsql function? Line 48: RETURNS SETOF gluster_hooks Line 49: AS $procedure$ Line 50: BEGIN Line 51: RETURN QUERY SELECT * Line 64: END; $procedure$ Line 65: LANGUAGE plpgsql; Line 66: Line 67: Line 68: Create or replace FUNCTION DeleteGlusterHookByName(v_cluster_id UUID, v_name VARCHAR(1000)) same as before Line 69: RETURNS VOID Line 70: AS $procedure$ Line 71: BEGIN Line 72: DELETE FROM gluster_hooks Line 158: Create or replace FUNCTION GetGlusterServerHook(v_hook_id UUID, v_host_id UUID) Line 159: RETURNS SETOF gluster_server_hooks Line 160: AS $procedure$ Line 161: BEGIN Line 162: IF v_host_id IS NULL THEN Trailing white space, please remove Line 163: RETURN QUERY SELECT * Line 164: FROM gluster_server_hooks Line 165: WHERE hook_id = v_hook_id AND host_id IS NULL; Line 166: ELSE Line 175: Create or replace FUNCTION GetGlusterServerHooks(v_cluster_id UUID, v_host_id UUID) Line 176: RETURNS SETOF gluster_server_hooks Line 177: AS $procedure$ Line 178: BEGIN Line 179: IF v_host_id IS NULL THEN Same Line 180: RETURN QUERY SELECT * Line 181: FROM gluster_server_hooks Line 182: WHERE host_id IS NULL AND hook_id IN (SELECT id FROM gluster_hooks WHERE cluster_id = v_cluster_id); Line 183: ELSE Line 235: Create or replace FUNCTION UpdateGlusterServerHookChecksum(v_hook_id UUID, v_host_id UUID, v_checksum VARCHAR(100)) Line 236: RETURNS VOID Line 237: AS $procedure$ Line 238: BEGIN Line 239: IF v_host_id IS NULL THEN Same Line 240: UPDATE gluster_server_hooks Line 241: SET checksum = v_checksum, Line 242: _update_date = LOCALTIMESTAMP Line 243: WHERE hook_id = v_hook_id AND host_id IS NULL; Line 273: Create or replace FUNCTION DeleteGlusterServerHook(v_hook_id UUID, v_host_id UUID) Line 274: RETURNS VOID Line 275: AS $procedure$ Line 276: BEGIN Line 277: IF v_host_id IS NULL THEN Same Line 278: DELETE FROM gluster_server_hooks Line 279: WHERE hook_id = v_hook_id AND host_id IS NULL; Line 280: ELSE Line 281: DELETE FROM gluster_server_hooks -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
