Alona Kaplan has uploaded a new change for review.

Change subject: webadmin: add plugged and link state columns to template->nics 
sub tab
......................................................................

webadmin: add plugged and link state columns to template->nics sub tab

Link state and plug state should be displayed for Templates on Network
Interfaces sub tab.

Added 3 columns-
- Combined (plugged + linked) status icon.
- Plugged.
- Link State.

Change-Id: Ib9ed230dd4baff141574e6cb585c413b5c2e575c
Bug-Url: https://bugzilla.redhat.com/907384
Signed-off-by: Alona Kaplan <[email protected]>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateInterfaceListModelTable.java
1 file changed, 30 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/11884/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateInterfaceListModelTable.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateInterfaceListModelTable.java
index dbe13fb..a46fcbb 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateInterfaceListModelTable.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateInterfaceListModelTable.java
@@ -6,7 +6,10 @@
 import org.ovirt.engine.ui.common.system.ClientStorage;
 import org.ovirt.engine.ui.common.uicommon.model.SearchableTableModelProvider;
 import org.ovirt.engine.ui.common.widget.action.UiCommandButtonDefinition;
+import org.ovirt.engine.ui.common.widget.table.column.BooleanColumn;
+import org.ovirt.engine.ui.common.widget.table.column.CheckboxColumn;
 import org.ovirt.engine.ui.common.widget.table.column.EnumColumn;
+import org.ovirt.engine.ui.common.widget.table.column.NicActivateStatusColumn;
 import org.ovirt.engine.ui.common.widget.table.column.TextColumnWithTooltip;
 import 
org.ovirt.engine.ui.common.widget.uicommon.AbstractModelBoundTableWidget;
 import org.ovirt.engine.ui.uicommonweb.UICommand;
@@ -24,6 +27,8 @@
 
     @Override
     public void initTable(CommonApplicationConstants constants) {
+        getTable().addColumn(new 
NicActivateStatusColumn<VmNetworkInterface>(), constants.empty(), "30px"); 
//$NON-NLS-1$
+
         TextColumnWithTooltip<VmNetworkInterface> nameColumn = new 
TextColumnWithTooltip<VmNetworkInterface>() {
             @Override
             public String getValue(VmNetworkInterface object) {
@@ -32,6 +37,20 @@
         };
         getTable().addColumn(nameColumn, constants.nameInterface());
 
+        CheckboxColumn<VmNetworkInterface> pluggedColumn = new 
CheckboxColumn<VmNetworkInterface>() {
+            @Override
+            public Boolean getValue(VmNetworkInterface object) {
+                return object.isPlugged();
+            }
+
+            @Override
+            protected boolean canEdit(VmNetworkInterface object) {
+                return false;
+            }
+        };
+
+        getTable().addColumnWithHtmlHeader(pluggedColumn, constants.plugged(), 
"60px"); //$NON-NLS-1$
+
         TextColumnWithTooltip<VmNetworkInterface> networkNameColumn = new 
TextColumnWithTooltip<VmNetworkInterface>() {
             @Override
             public String getValue(VmNetworkInterface object) {
@@ -40,6 +59,17 @@
         };
         getTable().addColumn(networkNameColumn, 
constants.networkNameInterface());
 
+        BooleanColumn<VmNetworkInterface> linkStateColumn =
+                new 
BooleanColumn<VmNetworkInterface>(constants.linkedNetworkInteface(),
+                        constants.unlinkedNetworkInteface()) {
+                    @Override
+                    protected Boolean getRawValue(VmNetworkInterface object) {
+                        return object.isLinked();
+                    }
+                };
+
+        getTable().addColumnWithHtmlHeader(linkStateColumn, 
constants.linkStateNetworkInteface(), "65px"); //$NON-NLS-1$
+
         TextColumnWithTooltip<VmNetworkInterface> typeColumn = new 
EnumColumn<VmNetworkInterface, VmInterfaceType>() {
             @Override
             protected VmInterfaceType getRawValue(VmNetworkInterface object) {


--
To view, visit http://gerrit.ovirt.org/11884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9ed230dd4baff141574e6cb585c413b5c2e575c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to