Roy Golan has posted comments on this change.
Change subject: engine: Performance improvement in clean up compensation data
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 415: * Delete the compensation data, so that we don't accidentaly try
to compensate it at a later time.
Line 416: */
Line 417: private void cleanUpCompensationData() {
Line 418: if (!(getCompensationContext() instanceof
NoOpCompensationContext)) {
Line 419:
getBusinessEntitySnapshotDAO().removeAllForCommandId(commandId);
suggestion - put a boolean field on the Context for deletion and use it instead
of the instanceOf
Line 420: }
Line 421: }
Line 422:
Line 423: public VdcReturnValueBase endAction() {
--
To view, visit http://gerrit.ovirt.org/11878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb256db6415c8fd5f45fcee5bae984739e61fec3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
