Allon Mureinik has uploaded a new change for review. Change subject: core: Remove default audit logging ......................................................................
core: Remove default audit logging Removed the notion of default logging from AuditLogDirector and AuditLogableBase, as it literally did nothing. Change-Id: I00e2059f6793dcaaf909f28ab2428e04b9bf0281 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 2 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/11901/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java index 1a6cfc0..d0ac4c2 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java @@ -856,7 +856,6 @@ } } else if (auditLogable != null) { log.infoFormat("No string for {0} type. Use default Log", auditLogable.getAuditLogTypeValue()); - defaultLog(auditLogable); } } @@ -987,9 +986,5 @@ TypeCompat.getPropertyValues(logable, new HashSet<String>(attributes), returnValue); } return returnValue; - } - - private static void defaultLog(AuditLogableBase auditLogable) { - auditLogable.DefaultLog(); } } diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java index fc91289..a960b3a 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java @@ -432,9 +432,6 @@ } } - public void DefaultLog() { - } - public void AddCustomValue(final String name, final String value) { customValues.put(name.toLowerCase(), value); } -- To view, visit http://gerrit.ovirt.org/11901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I00e2059f6793dcaaf909f28ab2428e04b9bf0281 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
