Allon Mureinik has uploaded a new change for review. Change subject: core: Seriazlizable DiskImage comperators ......................................................................
core: Seriazlizable DiskImage comperators Both DiskImage comperators in the dal packages were not defined as serializable, which is considered to be a good defensive approach, especially since comperators are stateless, so serializing them is practically free. This addresses the FindBugs warning SE_COMPARATOR_SHOULD_BE_SERIALIZABLE on these classes. Change-Id: I0c0474da61a9d692bc35b2cb4b6d7e9be06edd34 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/11906/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java index ee80353..92d941d 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java @@ -1,10 +1,12 @@ package org.ovirt.engine.core.dal.comparators; +import java.io.Serializable; import java.util.Comparator; import org.ovirt.engine.core.common.businessentities.Disk; -public class DiskImageByBootComparator implements Comparator<Disk> { +public class DiskImageByBootComparator implements Comparator<Disk>, Serializable { + private static final long serialVersionUID = 4732164571328497830L; @Override public int compare(Disk o1, Disk o2) { diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java index d46f5eb..e2fe5a7 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java @@ -1,10 +1,12 @@ package org.ovirt.engine.core.dal.comparators; +import java.io.Serializable; import java.util.Comparator; import org.ovirt.engine.core.common.businessentities.Disk; -public class DiskImageByDiskAliasComparator implements Comparator<Disk> { +public class DiskImageByDiskAliasComparator implements Comparator<Disk>, Serializable { + private static final long serialVersionUID = 4948753716816170325L; @Override public int compare(Disk o1, Disk o2) { -- To view, visit http://gerrit.ovirt.org/11906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0c0474da61a9d692bc35b2cb4b6d7e9be06edd34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
